Comments on: AVL Tree Implementation in Clojure http://nflath.com/2009/07/avl-tree-implementation-in-clojure/ Technology-related ideas, mainly involving Emacs Sat, 19 May 2012 06:50:20 +0000 http://wordpress.org/?v=2.7.1 hourly 1 By: G Miller http://nflath.com/2009/07/avl-tree-implementation-in-clojure/comment-page-1/#comment-953 G Miller Thu, 12 Aug 2010 17:25:35 +0000 http://nflath.com/?p=185#comment-953 Do you have a working copy of the entire codebase? I did a copy-paste jobber on each expression, but when I run it I get: Clojure 1.2.0-RC2 1:1 user=> (avltree/test-all) java.lang.AssertionError: Assert failed: (< (balance-factor tree) 2) (repl-1:1) Do you have a working copy of the entire codebase? I did a copy-paste jobber on each expression, but when I run it I get:

Clojure 1.2.0-RC2
1:1 user=> (avltree/test-all)
java.lang.AssertionError: Assert failed: (< (balance-factor tree) 2) (repl-1:1)

]]> By: Martin Lübcke http://nflath.com/2009/07/avl-tree-implementation-in-clojure/comment-page-1/#comment-354 Martin Lübcke Wed, 30 Sep 2009 16:00:15 +0000 http://nflath.com/?p=185#comment-354 Haha, I see the problem now. My comments are sanitized, leaving them totally insane. I mean: “…you have missed passing the incoming < and > into the…” and the code should be: (< (tree :data) val) (tree-lookup (tree :right) val < >) I hope all less-than and greater-than are displayed now... Haha, I see the problem now. My comments are sanitized, leaving them totally insane. I mean: “…you have missed passing the incoming < and > into the…” and the code should be:
(< (tree :data) val) (tree-lookup (tree :right) val < >)
I hope all less-than and greater-than are displayed now…

]]> By: nflath http://nflath.com/2009/07/avl-tree-implementation-in-clojure/comment-page-1/#comment-353 nflath Wed, 30 Sep 2009 15:52:05 +0000 http://nflath.com/?p=185#comment-353 You are right, I'm fixing this now. You are right, I’m fixing this now.

]]> By: Martin Lübcke http://nflath.com/2009/07/avl-tree-implementation-in-clojure/comment-page-1/#comment-352 Martin Lübcke Wed, 30 Sep 2009 15:47:20 +0000 http://nflath.com/?p=185#comment-352 I meant "...you have missed passing the incoming into the..." so my question was not readable. Sorry. What I mean is that the custom will be used at the first comparison, but they will not be passed down in the recursion. I believe it should be: (< (tree :data) val) (tree-lookup (tree :right) val ) and the same for >. I meant “…you have missed passing the incoming into the…” so my question was not readable. Sorry.
What I mean is that the custom will be used at the first comparison, but they will not be passed down in the recursion. I believe it should be:
(< (tree :data) val) (tree-lookup (tree :right) val )
and the same for >.

]]> By: nflath http://nflath.com/2009/07/avl-tree-implementation-in-clojure/comment-page-1/#comment-336 nflath Tue, 29 Sep 2009 01:36:27 +0000 http://nflath.com/?p=185#comment-336 Martin: I don't understand the question - tree-lookup is correct, though. Martin: I don’t understand the question - tree-lookup is correct, though.

]]> By: Martin Lübcke http://nflath.com/2009/07/avl-tree-implementation-in-clojure/comment-page-1/#comment-334 Martin Lübcke Mon, 28 Sep 2009 20:18:51 +0000 http://nflath.com/?p=185#comment-334 This was really the example I was looking for. I'm new to functional programming and this was very explanatory. Nice to see something understandable beyond the Fibonacci sequence. Thank you for explaining it. I have one question: If I get it correctly you have missed passing the incoming in the recursive call of tree-lookup. Did I miss something? This was really the example I was looking for. I’m new to functional programming and this was very explanatory. Nice to see something understandable beyond the Fibonacci sequence. Thank you for explaining it.
I have one question: If I get it correctly you have missed passing the incoming in the recursive call of tree-lookup. Did I miss something?

]]>